Should Have Done Grammar: Mastering Past Modals for Perfect English Proficiency

Understanding "Should Have Done"
In English, "should have done" is a phrase used to express a recommendation or expectation that pertained to the past but did not happen. It's formed using "should" + "have" + the past participle of the verb. This structure helps indicate that there was an advisable action that didn't occur, often with a hint of regret or criticism.
How to Spot Real and Fake Words on the Duolingo English Test: Best Tips for SuccessWhen to Use "Should Have Done"
-
Expressing Regret: - Use "should have done" to talk about actions that would have been beneficial or desirable, but weren't taken. Here, it highlights what might have been the better course of action. - Example: "I should have studied more for the exam." This suggests that studying more would have been advantageous, likely leading to a better result.
-
Criticizing Past Actions: - When indicating that someone made a mistake or acted unwisely in the past, we can use "should have done." - Example: "You should have locked the door before leaving." This is implied criticism for failing to lock the door, which might have prevented an issue.
-
Advising on Past Situations: - It can be used to give advice for similar future situations by reflecting on past experiences. - Example: "To avoid future conflicts, we should have communicated more clearly."
-
Hypothetical Scenarios: - Illustrate situations that could have had different outcomes if an action had been taken. - Example: "If we had known about the traffic, we should have left earlier."
Examples in Everyday Conversation
- Regret in Personal Decisions:
- "She should have worn a coat; it was freezing outside."
- Reflecting on Past Mistakes:
- "We should have checked the weather forecast before planning the picnic."
- Advising a Friend:
- "You should have told me you were arriving early; I would have picked you up."
Forming Sentences
- Affirmative: You should have listened to their advice.
- Negative: They shouldn't have ignored the warning signs.
- Question: Should you have trusted him given the circumstances?
Using "should have done" effectively requires a good grasp of the past participle form of verbs. Practicing with various verbs will help learners gain fluency in expressing recommendations or reflecting on past decisions accurately.
Forming "Should Have Done" Sentences
To construct sentences using "should have done," you'll need to follow a simple pattern: use "should have" followed by the past participle form of the main verb. Here’s how you can form different types of sentences.
Affirmative Sentences
In an affirmative sentence, "should have" is used to express a recommendation or missed opportunity in the past.
Structure: Subject + should have + past participle + rest of the sentence
Examples: - "She should have accepted the job offer." - "We should have tried that new restaurant." - "They should have finished their homework earlier."
Negative Sentences
For negative sentences, add "not" after "have" to express something that was better left undone or avoided in the past.
Structure: Subject + should not have + past participle + rest of the sentence
Examples: - "I should not have eaten so much chocolate." - "You should not have skipped the meeting." - "He should not have spent all his money."
Contractions are very common in spoken English:
- "I shouldn't have eaten so much chocolate."
- "You shouldn't have skipped the meeting."
Interrogative Sentences
To form questions, start with "should," followed by the subject, "have," and then the past participle.
Structure: Should + subject + have + past participle + rest of the sentence?
Examples: - "Should we have called her earlier?" - "Should you have made a reservation?" - "Shouldn't they have invited you to the party?"
Past Participle Forms
To use "should have done" effectively, you need to be familiar with the past participle forms of verbs. These can be regular (ending in -ed) or irregular (which vary and should be memorized).
Regular Verbs Examples: - Walk → walked: "I should have walked instead of driven." - Play → played: "They should have played harder."
Irregular Verbs Examples: - Go → gone: "You should have gone to the concert." - Take → taken: "She should have taken her umbrella."
Practice Suggestions
- With Regular Verbs: Create sentences using verbs like "watch," "clean," and "cook."
- With Irregular Verbs: Write sentences using verbs like "choose," "write," and "see."
Practicing with these sentence structures and verb forms will help you effectively express past recommendations and missed opportunities.
Uses of "Should Have Done"
The phrase "should have done" is used to talk about past actions or decisions that, in hindsight, would have been better if they had been different. It expresses regret or implies that a different choice was advisable. Here are some common uses and examples:
Test Your EnglishExpressing Regret
When reflecting on past actions, "should have done" often conveys personal regret or missed opportunities:
- "I should have studied harder for the exam." (Regret for not studying enough)
- "She should have apologized sooner." (A better outcome might have been achieved with an earlier apology)
Offering Retrospective Advice
It can be used to suggest a better course of action that someone could have taken in a specific situation:
- "You should have asked for help when you were struggling." (Suggesting seeking help would have been beneficial)
- "He should have checked the weather before leaving." (Checking the weather might have prevented a problem)
Speculating About the Past
Sometimes we use "should have done" to speculate about past events and consider how different actions might have led to different outcomes:
- "We should have taken the other route; we would have avoided the traffic jam." (Speculating that another choice might have been better)
- "They should have arrived by now." (Guessing about someone's delay while inferring they might have taken a different decision)
Expressing Criticism
"Should have done" can be used to criticize or express disapproval of someone's actions:
- "The team should have practiced more before the match." (Implying their lack of preparation led to a suboptimal performance)
- "You should have listened to your parents' advice." (Critically pointing out the consequences of ignoring good advice)
Analyzing Missed Opportunities
It helps in discussing opportunities that were missed and the potential benefits that could have been achieved:
- "I should have invested in that company earlier." (Considering potential profits that could have been made)
- "We should have attended the conference last year; it would have been a great networking opportunity." (Reflecting on a missed chance for professional growth)
By practicing with these examples, you can better understand how "should have done" is used to convey regret, offer advice, speculate about past events, or express criticism about past actions.

Common Mistakes with "Should Have Done"
Learners of English often make common mistakes when using "should have done." Understanding these errors can help you avoid them in your own speech and writing. Here are some of the frequent pitfalls and how to steer clear of them:
Misusing the Base Form of Verbs
One frequent mistake is using the base form instead of the past participle after "should have." Remember, "should have" is followed by a past participle, not the base form of the verb.
- Incorrect: "I should have go to the party."
- Correct: "I should have gone to the party."
Confusion Between "Should Have" and "Should"
Learners sometimes use "should" when they mean "should have," especially when expressing regrets about the past. "Should" is used for present or future advice, while "should have" is for past situations.
- Incorrect: "You should tell her you were sorry."
- Correct: "You should have told her you were sorry."
Incorrect Contractions
Some people mistakenly use contractions like "should of" instead of the correct "should've" or "should have."
- Incorrect: "I should of called you."
- Correct: "I should have called you." or "I should've called you."
Overlooking Context
Sometimes, learners use "should have" without considering whether it's appropriate for the context, especially with future or unreal situations.
- Incorrect: "I should have see that movie tomorrow."
- Correct: "I should see that movie tomorrow." (for future)
- Use "should have" to express a past regret or missed opportunity, e.g., "I should have seen that movie when it was in theaters."
Mixing Tenses
It's crucial not to mix past and present tenses improperly around "should have."
- Incorrect: "You should have be more careful yesterday."
- Correct: "You should have been more careful yesterday."
Failing to Apply in Negative Sentences
Sometimes learners struggle with forming negative sentences using "should have."
- Incorrect: "You should have not skipped breakfast."
- Correct: "You should not have skipped breakfast." or "You shouldn't have skipped breakfast."
By paying attention to these common mistakes, you can enhance your proficiency in using "should have done" correctly in various contexts. Practicing consistently and reviewing these examples can aid in developing a natural understanding and use of this grammatical structure.
Practice Exercises for Mastery
By completing the exercises below, you can deepen your understanding of the "should have done" structure. Practice by transforming sentences, correcting errors, and crafting your own sentences.
Free English PracticeExercise 1: Sentence Transformation
Transform the following sentences to use "should have done":
-
"I missed the meeting." - Hint: Express regret. - Example: "I should have attended the meeting."
-
"She ignored the warning." - Hint: Offer a suggestion for past action. - Example: "She should have listened to the warning."
-
"They chose the wrong path." - Hint: Offer criticism about the past decision. - Example: "They should have chosen a different path."
Exercise 2: Error Correction
Identify and correct the mistakes in these sentences:
-
"You should studied for the exam." - Correction: "You should have studied for the exam."
-
"He should of been more careful." - Correction: "He should have been more careful."
-
"We should finished the project sooner." - Correction: "We should have finished the project sooner."
Exercise 3: Contextual Application
Write sentences using "should have done" to fit these contexts:
-
Expressing regret about not visiting a friend when you had the chance. - Example: "I should have visited my friend when I was in town."
-
Advising someone about taking an opportunity they missed. - Example: "You should have applied for that job when it was available."
-
Criticizing yourself for not speaking up in a meeting. - Example: "I should have voiced my opinion during the meeting."
Exercise 4: Crafting Your Own Sentences
Create your own sentences using "should have done" in each of the scenarios below:
-
Making a suggestion about past travel plans. - Example: "We should have booked our tickets earlier to get a discount."
-
Reflecting on a decision to skip a workout. - Example: "I should have gone to the gym yesterday."
-
Talking about a missed opportunity to learn something new. - Example: "I should have taken that online course when it was free."
By practicing these exercises, you'll improve your ability to use "should have done" effectively in various contexts. This will enhance your language skills and help you express past regrets, advice, or criticisms more naturally.
DET Study provides an extensive suite of over 15,000 practice questions, focusing on leveraging adjectives and adverbs to fortify your grammatical skills. Regular practice with these targeted materials ensures that you approach the Duolingo English Test with enhanced confidence and precision, ready to achieve your desired scores.
🎯 Need more practice? Check out DETStudy.com for expert resources, 15,000+ practice questions, and AI-powered writing and speaking feedback.
Frequently Asked Questions (FAQ)
What does "should have done" mean in English grammar?
How do you form sentences with "should have done"?
When do you use "should have done" instead of "ought to have done"?
